Skip to content

Conversation

@avi-alpert
Copy link
Contributor

Problem

The button "Update README with recent code changes" is not accurate since code changes might not be recent. Also, when a user requests specific changes for a README, the message "Okay, I'm updating the README to reflect your code changes" is confusing since this request may be unrelated to code changes.

Solution

Change button text to "Update README to reflect code", and change progress message to "Okay, I'm updating the README." Switch "might" to "may" as per writer guidance.

image image
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@avi-alpert avi-alpert requested a review from a team as a code owner January 9, 2025 18:00
@github-actions
Copy link

github-actions bot commented Jan 9, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@avi-alpert avi-alpert merged commit 072eecd into aws:master Jan 9, 2025
17 checks passed
@avi-alpert avi-alpert deleted the aalpert/text-changes branch January 9, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants